Added support for aws waf v2 #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inspec-aws canceled.
|
added 2 commits
September 17, 2023 18:48
Signed-off-by: Rob de Heer robertsdeheer@gmail.com
|
Given our recent updates to main and the train-aws v0.4.2 release you should be able to pull in upstream/main and your PR should hopefully pass to the next stage as the aws_sdk_wafv2 gem is now in train-aws. |
|
If you want to get this passing for now - add the needed gem to the Gemfile and this should get moving again. |
|
Documentation for the resources - which is likely a 'mostly copy' from the v1 docs - seems to be missing. |
| @@ -330,6 +331,10 @@ def waf_client | |||
| aws_client(Aws::WAF::Client) | |||
| end | |||
|
|
|||
| def waf_client_v2 | |||
| aws_client(Aws::WAFWAFV2::Client) | |||
There was a problem hiding this comment.
Looks like there is an extra 'WAF' here -
Aws::WAFV2::Client
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.
Issues Resolved
List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lintpasses